fix invalid validation error checking#5565
Merged
fuweid merged 1 commit intocontainerd:masterfrom Jun 4, 2021
Merged
Conversation
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
|
Build succeeded.
|
Member
|
Interesting find as well, the logic is backwards but it just ends up being a no-op because of |
dmcgowan
approved these changes
Jun 3, 2021
samuelkarp
approved these changes
Jun 3, 2021
fuweid
approved these changes
Jun 4, 2021
This was referenced Jun 8, 2021
fuweid
added a commit
that referenced
this pull request
Jun 9, 2021
[release/1.5] cherry pick #5565 to release 1.5 - fix invalid validation error checking
estesp
added a commit
that referenced
this pull request
Jun 9, 2021
[release/1.4] cherry pick #5565 to release 1.4 - fix invalid validation error checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateContainer and validateInfo returning immediately if a label exists
found these while reviewing if we had any issues regarding calling "github.com/pkg/errors"
.Wrapf(err,where err is nil... turns out yes. Was looking thanks to learning from #5560 that if wrapping nil you get nil ..** side note
github.com/hashicorp/errorwrap.Wrapfin our vendor tree (didn't check why) does in fact wrap nil with as<nil>and thus returns the nil wrapped vs returning nil)Signed-off-by: Mike Brown brownwm@us.ibm.com