runtime: ignore file-already-closed error if dead shim#5174
Merged
estesp merged 1 commit intocontainerd:masterfrom Mar 15, 2021
Merged
runtime: ignore file-already-closed error if dead shim#5174estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
fuweid
commented
Mar 12, 2021
runtime/v2/shim_unix.go
Outdated
Member
Author
|
/ok-to-test |
|
Build succeeded.
|
fix: containerd#5130 Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
Build succeeded.
|
fuweid
added a commit
to fuweid/containerd
that referenced
this pull request
Mar 18, 2021
After containerd#4906, containerd opens fifo in read/write mode in linux platform The original comment doesn't correct and is removed by containerd#5174. ``` // original comment // When using a multi-container shim, the fifo of the 2nd to Nth // container will not be opened when the ctx is done. This will // cause an ErrReadClosed that can be ignored. ``` However, we should add comment for checkCopyShimLogError to mention why we call checkCopyShimLogError. The checkCopyShimLogError, it is to prevent the flood of expected error messages after task die and the expected errors depend on platform. Signed-off-by: Wei Fu <fuweid89@gmail.com>
uubk
pushed a commit
to vsk8s/containerd
that referenced
this pull request
Sep 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #5130
Signed-off-by: Wei Fu fuweid89@gmail.com