Skip to content

Conversation

@crosbymichael
Copy link
Member

For some tools having the actual image name in the annotations is helpful for
debugging and auditing the workload.

Signed-off-by: Michael Crosby michael@thepasture.io

For some tools having the actual image name in the annotations is helpful for
debugging and auditing the workload.

Signed-off-by: Michael Crosby <michael@thepasture.io>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 4, 2021

Build succeeded.

  • containerd-build-arm64 : RETRY_LIMIT in 1m 00s (non-voting)

@crosbymichael crosbymichael added this to the 1.5 milestone Feb 4, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 4, 2021

Build succeeded.

  • containerd-build-arm64 : RETRY_LIMIT in 1m 00s (non-voting)

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit b3f2402 into containerd:master Feb 5, 2021
@crosbymichael crosbymichael deleted the anno-image-name branch February 5, 2021 19:01
lujinda added a commit to lujinda/containerd that referenced this pull request Sep 29, 2024
containerd#5002 image annotation can helpful for debugging and auditing the workload.
However, when an image has multiple tags, the image originally obtained may not be the one actually specified by the user.
Starting from cri-api v0.28.0, a UserSpecifiedImage field is added to ImageSpec.
It is more appropriate to use UserSpecifiedImage.

Signed-off-by: jinda.ljd <jinda.ljd@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants