Merged
Conversation
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
Build succeeded.
|
Member
|
Even if it is easy to upgrade go, it is still big change, at least to me. Could we just keep release1.2 using go1.12.x? |
Member
Author
|
1.2 is already using Go 1.13: 4f6dc01 |
Member
|
hmm. ok... |
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jun 23, 2020
Essentially cherry-picking containerd#4260 containerd#4333 (but without `git-cherry-pick(1)` due to the code divergence between v1.3 and master caused by CI changes) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jun 24, 2020
Essentially cherry-picking containerd#4260 containerd#4333 (but without `git-cherry-pick(1)` due to the code divergence between v1.2 and master caused by CI changes) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jun 26, 2020
Partially cherry-picks containerd#4333 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/golang/go/milestone/148?closed=1