[release/1.3 backport] Binary IO fixes and tests#4278
Merged
mxpv merged 3 commits intocontainerd:release/1.3from May 21, 2020
Merged
[release/1.3 backport] Binary IO fixes and tests#4278mxpv merged 3 commits intocontainerd:release/1.3from
mxpv merged 3 commits intocontainerd:release/1.3from
Conversation
|
Build succeeded.
|
containerd loads timeout values from config.toml and populated those values to `timeout` package at launch. So when using `timeout` package from shim, there are default values and config file is ignored. So use a hardcoded value for binary IO. Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
b0d2d98 to
0cca78f
Compare
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4195.
I know that we may not have 1.3.5 anytime soon though. Let me know if we have the right way to backport changes!