Merged
Conversation
containerd loads timeout values from config.toml and populated those values to `timeout` package at launch. So when using `timeout` package from shim, there are default values and config file is ignored. So use a hardcoded value for binary IO. Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
Signed-off-by: Maksym Pavlenko <makpav@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #4195 +/- ##
=======================================
Coverage 38.35% 38.35%
=======================================
Files 90 90
Lines 12726 12726
=======================================
Hits 4881 4881
Misses 7179 7179
Partials 666 666
Continue to review full report at Codecov.
|
|
Build succeeded.
|
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
May 21, 2020
This change upgrades containerd to post-1.3.4 for including containerd/containerd#4195.
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
May 21, 2020
This change upgrades containerd to post-1.3.4 for including containerd/containerd#4195. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
pushed a commit
to kzys/firecracker-containerd
that referenced
this pull request
May 21, 2020
This change upgrades containerd to post-1.3.4 for including containerd/containerd#4195. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
NewBinaryIO.timeoutpackage, since shim binary doesn't loadconfig.tomlfile and hence doesn't contain configured timeouts.