cgroup2: implement containerd.events.TaskOOM event#4273
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jun 1, 2020
Merged
cgroup2: implement containerd.events.TaskOOM event#4273crosbymichael merged 1 commit intocontainerd:masterfrom
containerd.events.TaskOOM event#4273crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Member
|
@AkihiroSuda will take a look today |
fuweid
reviewed
May 28, 2020
Member
fuweid
left a comment
There was a problem hiding this comment.
The change looks good but I think we can add log for error :)
How to test (from opencontainers/runc#2352 (comment)): (host)$ sudo swapoff -a (host)$ sudo ctr run -t --rm --memory-limit $((1024*1024*32)) docker.io/library/alpine:latest foo (container)$ sh -c 'VAR=$(seq 1 100000000)' An event `/tasks/oom {"container_id":"foo"}` will be displayed in `ctr events`. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test (from opencontainers/runc#2352 (comment)):
An event
/tasks/oom {"container_id":"foo"}will be displayed inctr events.DRAFT: Requires containerd/cgroups#158