Merged
Conversation
Member
Author
|
@Zyqsempai @fuweid PTAL |
a604614 to
ece7561
Compare
ece7561 to
d43a1d0
Compare
EventChan() was completely broken:
* [critical] `err == nil` comparison was flipped in the opposite way
* [critical] `var out map[string]interface{}` was not initialized with `make()`
* [non-critical] `.(uint64)` conversin errors were not caught
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
d43a1d0 to
7a4b407
Compare
Member
Author
|
rebased |
fuweid
approved these changes
May 20, 2020
Member
fuweid
left a comment
There was a problem hiding this comment.
LGTM 👍
Good night @AkihiroSuda :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventChan() was completely broken:
err == nilcomparison was flipped in the opposite wayvar out map[string]interface{}was not initialized withmake().(uint64)conversin errors were not caught