bugfix: override image.Env with process.Env, rather than be contrary#3542
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 16, 2019
Merged
bugfix: override image.Env with process.Env, rather than be contrary#3542estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
Signed-off-by: Yangyang <1032120121@163.com>
b3e6b05 to
1c30d4d
Compare
|
Build succeeded.
|
Member
|
LGTM logic looks correct to me |
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
Aug 19, 2019
With the change in containerd#3542 it breaks $PATH handling for images becuase our default spec always sets a PATH on the process's .Env. This removes the default and adds an Opt to add this back. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
estesp
pushed a commit
to estesp/containerd
that referenced
this pull request
Aug 20, 2019
With the change in containerd#3542 it breaks $PATH handling for images becuase our default spec always sets a PATH on the process's .Env. This removes the default and adds an Opt to add this back. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
With the change in containerd#3542 it breaks $PATH handling for images becuase our default spec always sets a PATH on the process's .Env. This removes the default and adds an Opt to add this back. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Env in image should be default value, it should has override by the Env in process. otherwise the Env in image is immutable, setting the Env in process will be meaningless