Skip to content

Refactor runtime package for code usage#3374

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:runtime
Jul 8, 2019
Merged

Refactor runtime package for code usage#3374
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:runtime

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael commented Jun 25, 2019

Refactor runtime code to share among runtimes more easily.

Ref: #3285

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jun 25, 2019

Build succeeded.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 2, 2019

Build succeeded.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 2, 2019

Codecov Report

Merging #3374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3374   +/-   ##
=======================================
  Coverage   45.05%   45.05%           
=======================================
  Files         113      113           
  Lines       12563    12563           
=======================================
  Hits         5660     5660           
  Misses       6049     6049           
  Partials      854      854
Flag Coverage Δ
#linux 48.98% <ø> (ø) ⬆️
#windows 40.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa8780...6601b40. Read the comment docs.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 8, 2019

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Jul 8, 2019

Travis status back to PR seems broken; passed: https://travis-ci.org/containerd/containerd/builds/555861353

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a0696b2 into containerd:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants