Skip to content

Refactor code in runtime v1/v2 #3285

@Ace-Tang

Description

@Ace-Tang

Current we get two version runtime in containerd, runtime v1 and v2, v2 also has two version, name them as v2-v1 and v2-v2.

Although runtime v1 will be deprecated, but it still need some time, I want say that many code in two version runtime is repeat, like shim reaper part, runtime/v1/shim/reaper.go runtime/v2/shim/reaper_unix.go, they two just named different. And runtime v2 calls proc code locate in v1, github.com/containerd/containerd/runtime/v1/linux/proc, it may can be move to some common part.

This is what I thought, I wonder if it is worth to do something, 😕

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions