Skip to content

Fix error handling for task deletion.#3263

Merged
estesp merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-task-deletion
May 7, 2019
Merged

Fix error handling for task deletion.#3263
estesp merged 1 commit intocontainerd:masterfrom
Random-Liu:fix-task-deletion

Conversation

@Random-Liu
Copy link
Member

Follow up of #3244.

I'm really sorry... I think I had a typo in that fix.

Signed-off-by: Lantao Liu lantaol@google.com

Signed-off-by: Lantao Liu <lantaol@google.com>
@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #3263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3263   +/-   ##
=======================================
  Coverage   44.65%   44.65%           
=======================================
  Files         113      113           
  Lines       12160    12160           
=======================================
  Hits         5430     5430           
  Misses       5897     5897           
  Partials      833      833
Flag Coverage Δ
#linux 48.66% <ø> (ø) ⬆️
#windows 39.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf1356...660554d. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit d68b593 into containerd:master May 7, 2019
estesp added a commit that referenced this pull request May 8, 2019
…ase-1.2

[release/1.2] Return NotFound error for kill and delete in deleted state.
estesp added a commit that referenced this pull request May 8, 2019
…ase-1.1

[release/1.1] Return NotFound error for kill and delete in deleted state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants