[release/1.2] Add new required vndr go.mod files#3257
Merged
dmcgowan merged 1 commit intocontainerd:release/1.2from May 3, 2019
jcordasc:jcordasc/vndr-go-mod-only
Merged
[release/1.2] Add new required vndr go.mod files#3257dmcgowan merged 1 commit intocontainerd:release/1.2from jcordasc:jcordasc/vndr-go-mod-only
dmcgowan merged 1 commit intocontainerd:release/1.2from
jcordasc:jcordasc/vndr-go-mod-only
Conversation
Signed-off-by: Jared Cordasco <jcordasc@coglib.com>
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3257 +/- ##
============================================
Coverage 43.74% 43.74%
============================================
Files 101 101
Lines 10743 10743
============================================
Hits 4700 4700
Misses 5311 5311
Partials 732 732
Continue to review full report at Codecov.
|
thaJeztah
approved these changes
May 1, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (not a maintainer)
thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #3249, we need to commit the
go.modfiles produced by the latest version of vndr. For 1.2, onlygopkg.in/yaml.v2has a vendored version that includes ago.modfile.Signed-off-by: Jared Cordasco jcordasc@coglib.com