Skip to content

Update vendor/ with new required vndr go.mod files#3249

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
msg555:vndr_update
Apr 29, 2019
Merged

Update vendor/ with new required vndr go.mod files#3249
dmcgowan merged 1 commit intocontainerd:masterfrom
msg555:vndr_update

Conversation

@msg555
Copy link
Contributor

@msg555 msg555 commented Apr 28, 2019

As @thaJeztah in Slack vndr recently updated and now creates additional go.mod files that need to be included to pass the CI vendor checks.

See LK4D4/vndr#75 for the recently merged change.

Signed-off-by: msg555 <msg555@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #3249 into master will decrease coverage by 4.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
- Coverage   48.65%   44.63%   -4.02%     
==========================================
  Files         102      113      +11     
  Lines        9570    12164    +2594     
==========================================
+ Hits         4656     5430     +774     
- Misses       4088     5899    +1811     
- Partials      826      835       +9
Flag Coverage Δ
#linux 48.65% <ø> (ø) ⬆️
#windows 39.87% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.04% <0%> (-9.99%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.79% <0%> (-7.07%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 58.65% <0%> (-5.55%) ⬇️
content/local/store.go 49.51% <0%> (-5.15%) ⬇️
metadata/images.go 57.57% <0%> (-4.99%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
archive/compression/compression.go 58.69% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53830f6...c7f067f. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants