Skip to content

update opencontainers/runc v1.0.0-rc7#3139

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_runc_v1.0.0-rc7
Mar 29, 2019
Merged

update opencontainers/runc v1.0.0-rc7#3139
AkihiroSuda merged 1 commit intocontainerd:masterfrom
thaJeztah:bump_runc_v1.0.0-rc7

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 28, 2019

full diff: opencontainers/runc@2b18fe1...v1.0.0-rc7

changes included:

- opencontainers/runc#2012 Need to setup labeling of kernel keyrings
- opencontainers/runc#2014 Add $RUNC_USE_SYSTEMD to run tests using systemd cgroup driver
- opencontainers/runc#2015 Use getenv not secure_getenv
  - fixes opencontainers/runc#2013 build fails with musl libc
- opencontainers/runc#2023 Fixes regression causing zombie runc:[1:CHILD] processes

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #3139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3139   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files         104      104           
  Lines       11159    11159           
=======================================
  Hits         4865     4865           
  Misses       5555     5555           
  Partials      739      739
Flag Coverage Δ
#linux 47.59% <ø> (ø) ⬆️
#windows 40.49% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a20ea...bc6ac08. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 3a80a80 into containerd:master Mar 29, 2019
@thaJeztah thaJeztah deleted the bump_runc_v1.0.0-rc7 branch March 29, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build fails with musl libc

6 participants