ensure we call wait() on children created by nsenter#1966
Closed
pepin wants to merge 1 commit intoopencontainers:masterfrom
Closed
ensure we call wait() on children created by nsenter#1966pepin wants to merge 1 commit intoopencontainers:masterfrom
pepin wants to merge 1 commit intoopencontainers:masterfrom
Conversation
we were ending up with 1 zombie for every container created, since nothing was waiting on the intermediate child created by nsenter. Signed-off-by: James Pepin <james.pepin@gmail.com>
|
I have the same issue, so I tried the patch and it solved it. So a 👍 from me. |
Member
|
This should be fixed by #2023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were ending up with 1 zombie for every container created, since
nothing was waiting on the intermediate child created by nsenter.
Signed-off-by: James Pepin james.pepin@gmail.com