Add timeout and cancel to shim fifo open#2877
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Dec 14, 2018
Merged
Add timeout and cancel to shim fifo open#2877crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
There is still a special case where the client side fails to open or load causes things to be slow and the shim can lock up when this happens. This adds a timeout to the context for this case to abort fifo creation. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2877 +/- ##
=======================================
Coverage 43.87% 43.87%
=======================================
Files 101 101
Lines 10796 10796
=======================================
Hits 4737 4737
Misses 5328 5328
Partials 731 731
Continue to review full report at Codecov.
|
seemethere
approved these changes
Dec 13, 2018
Contributor
|
+1 |
Member
|
LGTM |
3 tasks
Random-Liu
added a commit
to Random-Liu/gvisor-containerd-shim
that referenced
this pull request
Jan 15, 2019
Signed-off-by: Lantao Liu <lantaol@google.com>
ianlewis
pushed a commit
to google/gvisor-containerd-shim
that referenced
this pull request
Jan 15, 2019
Adds a timeout and cancel to shim fifo open Signed-off-by: Lantao Liu <lantaol@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is still a special case where the client side fails to open or
load causes things to be slow and the shim can lock up when this
happens. This adds a timeout to the context for this case to abort fifo
creation.
Signed-off-by: Michael Crosby crosbymichael@gmail.com