Add WithTimeout as client Opt#2554
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 16, 2018
Merged
Conversation
This also sets the default timeout to 10s instead of 60s. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2554 +/- ##
=======================================
Coverage 44.59% 44.59%
=======================================
Files 95 95
Lines 10007 10007
=======================================
Hits 4463 4463
Misses 4822 4822
Partials 722 722
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Aug 16, 2018
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Aug 23, 2018
The contained default value was shortened from 60s to 10s in containerd/containerd#2554 However, 10s seems too short on Travis. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Aug 23, 2018
The contained default value was shortened from 60s to 10s in containerd/containerd#2554 However, 10s seems too short on Travis. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Aug 23, 2018
The contained default value was shortened from 60s to 10s in containerd/containerd#2554 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
Aug 23, 2018
The contained default value was shortened from 60s to 10s in containerd/containerd#2554 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
crazy-max
pushed a commit
to crazy-max/dockerfile
that referenced
this pull request
Jan 8, 2022
The contained default value was shortened from 60s to 10s in containerd/containerd#2554 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also sets the default timeout to 10s instead of 60s.
Signed-off-by: Michael Crosby crosbymichael@gmail.com