Fix sandbox task API endpoints for non-runc runtimes by mxpv · Pull Request #13360 · containerd/containerd

mxpv · 2026-05-07T22:02:00Z

I believe we overlooked this in #9736 and introduced task API address and version fields in Runc options.

Those are used in Sandbox API flow and have nothing to do with runc specifically.
As the result it doesn't work with other runtimes - #12986

This PR deprecates fields introduced in runc options and moves them to CreateTaskRequest.

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

Copilot

Pull request overview

This PR fixes sandbox task API endpoint handling for non-runc runtimes by moving the task API endpoint fields out of runc-specific runtime options and into the generic Tasks CreateTaskRequest, while keeping backward compatibility via deprecated runc option fields.

Changes:

Add task_api_address / task_api_version to CreateTaskRequest and plumb them through the client and task service.
Deprecate task_api_address / task_api_version in runc options protos and generated code.
Switch the repo to use the in-tree ./api module via a replace, updating vendoring metadata accordingly.

Reviewed changes

Copilot reviewed 9 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
vendor/modules.txt	Updates vendoring metadata for `github.com/containerd/containerd/api` to use `./api`.
vendor/github.com/containerd/containerd/api/types/runc/options/oci.proto	Marks runc option fields for task API endpoint as deprecated (vendored copy).
vendor/github.com/containerd/containerd/api/types/runc/options/oci.pb.go	Regenerates vendored Go bindings with deprecation annotations.
vendor/github.com/containerd/containerd/api/services/tasks/v1/tasks.proto	Adds task API endpoint fields to `CreateTaskRequest` (vendored copy).
vendor/github.com/containerd/containerd/api/LICENSE	Removes vendored API module LICENSE file.
plugins/services/tasks/local.go	Reads task API endpoint from `CreateTaskRequest` and keeps fallback to deprecated runc options.
go.sum	Drops sums for the now-replaced `github.com/containerd/containerd/api` module.
go.mod	Adds `replace github.com/containerd/containerd/api => ./api`.
client/task.go	Extends `TaskInfo` to carry task API endpoint info.
client/task_opts.go	Updates `WithTaskAPIEndpoint` to set `TaskInfo` fields instead of mutating runc options.
client/container.go	Plumbs `TaskInfo` task API endpoint fields into `CreateTaskRequest`.
api/types/runc/options/oci.proto	Marks runc option fields for task API endpoint as deprecated (source copy).
api/types/runc/options/oci.pb.go	Regenerates Go bindings with deprecation annotations.
api/services/tasks/v1/tasks.proto	Adds task API endpoint fields to `CreateTaskRequest` (source copy).
api/services/tasks/v1/tasks.pb.go	Regenerates Go bindings for tasks service request fields.
api/next.txtpb	Regenerates Buf descriptor output to reflect proto/API changes.
api/buf.lock	Updates Buf dependency lock metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fidencio · 2026-05-07T22:07:55Z

cc @Apokleos, as this solves the issue you're hitting on kata-containers/kata-containers#12957

@mxpv, it'd be nice to have this one backported to the 2.3 branch

Thanks for the quick fix, btw! :-)

Copilot

Pull request overview

Copilot reviewed 9 out of 18 changed files in this pull request and generated 2 comments.

containerd 2.3 requires Go 1.26.3, but Kata still pins Go 1.25.10. Use Go 1.26.3 for the sandbox-api job so that make cri-integration can build containerd from source. Checkout containerd/containerd#13360 which moves the task API address/version fields out of runc-specific options into CreateTaskRequest, fixing the sandbox API flow for non-runc runtimes. Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>

fidencio

lgtm, and has been tested on the Kata Containers side.
thanks, @mxpv!

dims

LGTM.

there's a comment from @samuelkarp though :)

mikebrow

LGTM
see note to self regarding lack of doc/defaulting for these two fields being deprecated as runc options

mikebrow · 2026-05-18T17:57:59Z

  // task api address, can be a unix domain socket, or vsock address.
  // it is in the form of ttrpc+unix://path/to/uds or grpc+vsock://<vsock cid>:<port>.
-  string task_api_address = 12;
+  string task_api_address = 12 [deprecated = true];


note to self... these two now deprecated fields taskapiaddress and taskapiversion were never documented in the config.md, nor defaulted for display with the containerd config default command.

Copilot

Pull request overview

Copilot reviewed 7 out of 18 changed files in this pull request and generated 2 comments.

Files not reviewed (2)

api/services/tasks/v1/tasks.pb.go: Language not supported
api/types/runc/options/oci.pb.go: Language not supported

mikebrow

additional log entries also LGTM

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 19 changed files in this pull request and generated 1 comment.

Files not reviewed (2)

api/services/tasks/v1/tasks.pb.go: Language not supported
api/types/runc/options/oci.pb.go: Language not supported

samuelkarp · 2026-05-18T23:08:45Z

 	CgroupV1:      "The support for cgroup v1 is deprecated since containerd v2.2 and will be removed by no later than May 2029. Upgrade the host to use cgroup v2.",
 	CRIEnableCDI:  "The `enable_cdi` property of `[plugins.\"io.containerd.cri.v1.runtime\"]` is deprecated, will be removed in containerd v2.3, and CDI support will always be enabled.",
+
+	RuncOptionsTaskAPIAddress: "The `task_api_address` field in runc options is deprecated since containerd v2.3. Set `task_api_address` on CreateTaskRequest instead.",


Since 2.3? Planning to cherry-pick this back?

Yes, it'd be good to cherry-pick this to 2.3

mxpv · 2026-05-19T03:17:47Z

/cherry-pick release/2.3

k8s-infra-cherrypick-robot · 2026-05-19T03:18:36Z

@mxpv: new pull request created: #13422

Details

In response to this:

/cherry-pick release/2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

protos: include task API address to CreateTaskRequest

ac01ae5

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

Copilot AI review requested due to automatic review settings May 7, 2026 22:02

github-project-automation Bot added this to Pull Request Review May 7, 2026

github-project-automation Bot moved this to Needs Triage in Pull Request Review May 7, 2026

k8s-ci-robot added the size/XXL label May 7, 2026

Copilot started reviewing on behalf of mxpv May 7, 2026 22:02 View session

mxpv added the impact/deprecation label May 7, 2026

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread plugins/services/tasks/local.go

Comment thread go.mod

mxpv force-pushed the task branch from fe694bb to a974cef Compare May 7, 2026 22:08

Copilot AI review requested due to automatic review settings May 7, 2026 22:12

mxpv force-pushed the task branch from a974cef to 9900213 Compare May 7, 2026 22:12

Copilot started reviewing on behalf of mxpv May 7, 2026 22:12 View session

mxpv added kind/bug cherry-pick/2.3.x Change to be cherry picked to release/2.3 labels May 7, 2026

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread client/task.go

Comment thread go.mod

mxpv moved this from Needs Triage to Needs Reviewers in Pull Request Review May 11, 2026

cpuguy83 approved these changes May 11, 2026

View reviewed changes

fidencio approved these changes May 18, 2026

View reviewed changes

fidencio mentioned this pull request May 18, 2026

runtime-rs: Fix sandbox-api lifecycle and CRI status handling kata-containers/kata-containers#12957

Merged

samuelkarp reviewed May 18, 2026

View reviewed changes

Comment thread plugins/services/tasks/local.go Outdated

dims approved these changes May 18, 2026

View reviewed changes

github-project-automation Bot moved this from Needs Reviewers to Review In Progress in Pull Request Review May 18, 2026

mikebrow approved these changes May 18, 2026

View reviewed changes

mxpv force-pushed the task branch from 9900213 to f943811 Compare May 18, 2026 18:18

Copilot AI review requested due to automatic review settings May 18, 2026 18:21

mxpv force-pushed the task branch from f943811 to 2f738e6 Compare May 18, 2026 18:21

Copilot started reviewing on behalf of mxpv May 18, 2026 18:21 View session

mxpv mentioned this pull request May 18, 2026

[release/2.3] Prepare release notes for v2.3.1 #13405

Merged

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread client/task.go

Comment thread plugins/services/tasks/local.go

mikebrow approved these changes May 18, 2026

View reviewed changes

mxpv force-pushed the task branch 2 times, most recently from 94aa30d to e55f5ef Compare May 18, 2026 19:07

mxpv requested a review from samuelkarp May 18, 2026 19:07

dmcgowan reviewed May 18, 2026

View reviewed changes

Comment thread client/task_opts.go

Wire task address and version fields

b88ab5a

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>

Copilot AI review requested due to automatic review settings May 18, 2026 20:37

mxpv force-pushed the task branch from e55f5ef to b88ab5a Compare May 18, 2026 20:37

Copilot started reviewing on behalf of mxpv May 18, 2026 20:37 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread client/task.go

mxpv requested a review from dmcgowan May 18, 2026 20:44

dmcgowan approved these changes May 18, 2026

View reviewed changes

samuelkarp approved these changes May 18, 2026

View reviewed changes

samuelkarp enabled auto-merge May 18, 2026 23:35

samuelkarp added this pull request to the merge queue May 19, 2026

Merged via the queue into containerd:main with commit ae843af May 19, 2026
161 of 181 checks passed

github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review May 19, 2026

k8s-infra-cherrypick-robot mentioned this pull request May 19, 2026

[release/2.3] Fix sandbox task API endpoints for non-runc runtimes #13422

Merged

mxpv deleted the task branch May 19, 2026 18:08

dmcgowan added cherry-picked/2.2.x PR commits are cherry-picked into release/2.2 branch cherry-picked/2.3.x PR commits are cherry picked into release/2.3 branch and removed cherry-pick/2.3.x Change to be cherry picked to release/2.3 labels May 20, 2026

Conversation

mxpv commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

fidencio commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

fidencio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dims left a comment

Choose a reason for hiding this comment

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

mikebrow May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

samuelkarp May 18, 2026

Choose a reason for hiding this comment

Uh oh!

mxpv May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mxpv commented May 19, 2026

Uh oh!

k8s-infra-cherrypick-robot commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mxpv commented May 7, 2026 •

edited

Loading

mxpv May 18, 2026 •

edited

Loading