Skip to content

ci: bump Go 1.24.9, 1.25.3 #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 1 commit into from
Nov 4, 2025
Merged

ci: bump Go 1.24.9, 1.25.3 #12464

AkihiroSuda merged 1 commit into from
Nov 4, 2025

Conversation

@austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented Nov 4, 2025

This change bumps the golang version used in CI to Go 1.24.9.

go1.24.9 (released 2025-10-13) includes fixes to the crypto/x509 package. See the Go 1.24.9 milestone on our issue tracker for details.

full diff: golang/go@go1.24.8...go1.24.9

@austinvazquez austinvazquez requested a review from Copilot November 4, 2025 14:43
@austinvazquez austinvazquez self-assigned this Nov 4, 2025
@austinvazquez austinvazquez added cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Nov 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Nov 4, 2025
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go version from 1.24.8 to 1.24.9 across all CI and development environment configuration files to incorporate security fixes in the crypto/x509 package.

  • Updates Go version to 1.24.9 in CI workflows and development environments
  • Updates Go 1.25.2 to 1.25.3 in the CI matrix
  • Ensures consistent Go version usage across all build and development tooling

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
script/setup/prepare_env_windows.ps1 Updates Go version in Windows setup script
contrib/fuzz/oss_fuzz_build.sh Updates Go download URLs and tar extraction for fuzzing builds
contrib/Dockerfile.test Updates Go version argument in test Dockerfile
Vagrantfile Updates default Go version for Vagrant provisioning
.github/workflows/release.yml Updates Go version environment variable for release workflow
.github/workflows/ci.yml Updates Go version matrix from 1.24.8/1.25.2 to 1.24.9/1.25.3
.github/workflows/api-release.yml Updates Go version environment variable for API release workflow
.github/actions/install-go/action.yml Updates default Go version in reusable action
.devcontainer/devcontainer.json Updates Go version in development container configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added area/toolchain Build and Release Toolchain github_actions Pull requests that update GitHub Actions code labels Nov 4, 2025
akhilerm
akhilerm approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the commit message description since we are updating 1.25.2 to 1.25.3 also in CI

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Nov 4, 2025
@austinvazquez
ci: bump Go 1.24.9, 1.25.3
acbaa8a 
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@austinvazquez austinvazquez changed the title ci: bump Go 1.24.9 ci: bump Go 1.24.9, 1.25.3 Nov 4, 2025
@AkihiroSuda AkihiroSuda enabled auto-merge November 4, 2025 15:25
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Nov 4, 2025
Merged via the queue into containerd:main with commit c32c421 Nov 4, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Nov 4, 2025
@austinvazquez austinvazquez deleted the bump-go-1.24.9 branch November 4, 2025 17:05
@austinvazquez
Copy link
Member Author

austinvazquez commented Nov 4, 2025

/cherry-pick release/2.1

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 4, 2025

@austinvazquez: #12464 failed to apply on top of branch "release/2.1":

Applying: ci: bump Go 1.24.9, 1.25.3
Using index info to reconstruct a base tree...
M	.github/workflows/api-release.yml
M	.github/workflows/ci.yml
M	.github/workflows/release.yml
M	contrib/Dockerfile.test
Falling back to patching base and 3-way merge...
Auto-merging contrib/Dockerfile.test
Auto-merging .github/workflows/release.yml
Auto-merging .github/workflows/ci.yml
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
Auto-merging .github/workflows/api-release.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 ci: bump Go 1.24.9, 1.25.3
Details

In response to this:

/cherry-pick release/2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Nov 4, 2025
Merged
Merged
Merged
@austinvazquez austinvazquez added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch cherry-pick/2.1.x Change to be cherry picked to release/2.1 branch labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@estesp estesp estesp approved these changes

@akhilerm akhilerm akhilerm approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@austinvazquez austinvazquez

Labels

area/toolchain Build and Release Toolchain cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch cherry-picked/2.1.x PR commits are cherry picked into the release/2.1 branch github_actions Pull requests that update GitHub Actions code size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@austinvazquez @k8s-infra-cherrypick-robot @estesp @akhilerm @AkihiroSuda @k8s-ci-robot