Skip to content

Fix CI lint error#11555

Merged
estesp merged 1 commit intocontainerd:mainfrom
djdongjin:fix-ci-lint-error
Mar 18, 2025
Merged

Fix CI lint error#11555
estesp merged 1 commit intocontainerd:mainfrom
djdongjin:fix-ci-lint-error

Conversation

@djdongjin
Copy link
Member

@djdongjin djdongjin commented Mar 18, 2025 •
edited by thaJeztah
Loading

https://github.com/containerd/containerd/actions/runs/13911860592/job/38927588065?pr=11554

  Error: pkg/oci/spec_opts_linux_test.go:108:3: The copy of the 'for' variable "testCase" can be deleted (Go 1.22+) (copyloopvar)
  		testCase := testCase
  		^
  Error: pkg/oci/spec_opts.go:598:1: File is not properly formatted (gofmt)
                  // and the OCI Runtime Spec has no definition about the max UID,
  ^

@djdongjin
Fix CI lint error
c8effff 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Mar 18, 2025
@dosubot dosubot bot added area/github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Mar 18, 2025
@djdongjin djdongjin mentioned this pull request Mar 18, 2025
Closed
thaJeztah
thaJeztah approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 18, 2025
@estesp estesp added this pull request to the merge queue Mar 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 18, 2025
@estesp estesp added this pull request to the merge queue Mar 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
@estesp
Merge pull request #11555 from djdongjin/fix-ci-lint-error
8f94ad0 
Fix CI lint error
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2025
@estesp estesp added this pull request to the merge queue Mar 18, 2025
Merged via the queue into containerd:main with commit 57d29ee Mar 18, 2025
58 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Mar 18, 2025
@klihub klihub mentioned this pull request Mar 19, 2025
Merged
AkihiroSuda added a commit that referenced this pull request Mar 19, 2025
@AkihiroSuda
Merge pull request #11567 from klihub/fixes/2.0/ci-lint-errors
dcd661b 
[release/2.0] Fix CI lint error (cherry-picked #11555)
@dmcgowan dmcgowan mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees

No one assigned

Labels

area/github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code size/S

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@djdongjin @dmcgowan @estesp @thaJeztah @austinvazquez @k8s-ci-robot