Skip to content

Switch to go 1.24 #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saschagrunert wants to merge 1 commit into from
Closed

Switch to go 1.24 #11533

saschagrunert wants to merge 1 commit into from

Conversation

@saschagrunert
Copy link
Contributor

@saschagrunert saschagrunert commented Mar 12, 2025

The latest NRI wasm support will require go 1.24. Means we switch to the latest golang minor ahead of time to allow seamless upgrades.

Refers to containerd/nri#148

@saschagrunert
Switch to go 1.24
36f2286 
The latest NRI wasm support will require go 1.24. Means we switch to the
latest golang minor ahead of time to allow seamless upgrades.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Mar 12, 2025
@k8s-ci-robot
Copy link

k8s-ci-robot commented Mar 12, 2025

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the go Pull requests that update Go code label Mar 12, 2025
@saschagrunert saschagrunert mentioned this pull request Mar 12, 2025
Merged
akhilerm
akhilerm reviewed Mar 12, 2025
View reviewed changes
go.mod
module github.com/containerd/containerd/v2

go 1.23.0
go 1.24
Copy link
Member

@akhilerm akhilerm Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have to look into the NRI side of changes. But this will force the minimal version to 1.24. Is it possible to keep the go.mod version at 1.23 in NRI and toolchain at 1.24?

@samuelkarp
Copy link
Member

samuelkarp commented Mar 13, 2025

Copying my comment over from containerd/nri#148 (comment)

this will also be a breaking change, WASM plugins compiled with tinygo will not work with golang ones because the underlying library changed
[...]
Proposing the new golang version in #11533

Oof. So for containerd, either we:

  1. Require 1.24 in 2.1 (which can make it hard for distros to ship 2.1, delaying adoption), or
  2. Don't take 1.24 in 2.1 and ship 2.1 with the initial tinygo-based WASM support, and then immediately break that in the next release (2.2)
  3. Disable WASM in 2.1 and take the 1.24 minimum version change in 2.2 (which will be more reasonable timing-wise as Go 1.23 will have reached EOL)

None of those sound like great choices to me. I think option 2 sounds the worst though.

@samuelkarp
Copy link
Member

samuelkarp commented Mar 13, 2025

Per the community call today, we do not plan to require Go 1.24 in containerd 2.1.

@samuelkarp samuelkarp closed this Mar 13, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Pull Request Review Mar 13, 2025
@saschagrunert saschagrunert deleted the go-1.24 branch March 14, 2025 08:03
@djdongjin djdongjin mentioned this pull request Mar 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilerm akhilerm akhilerm left review comments

Assignees

No one assigned

Labels

go Pull requests that update Go code needs-ok-to-test size/XS

Projects

Pull Request Review
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschagrunert @k8s-ci-robot @samuelkarp @akhilerm