Skip to content

ci: update GitHub Actions release runner to ubuntu-24.04#11479

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
austinvazquez:update-gha-runner-image-to-ubuntu-24.04
Mar 6, 2025
Merged

ci: update GitHub Actions release runner to ubuntu-24.04#11479
AkihiroSuda merged 1 commit intocontainerd:mainfrom
austinvazquez:update-gha-runner-image-to-ubuntu-24.04

Conversation

@austinvazquez
Copy link
Member

Ubuntu 20.04 GitHub Actions runners are deprecated. This change updates the release runner to use Ubuntu 24.04.

actions/runner-images#11101

Signed-off-by: Austin Vazquez macedonv@amazon.com

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Mar 4, 2025
@dosubot dosubot bot added area/toolchain Build and Release Toolchain area/github_actions Pull requests that update GitHub Actions code labels Mar 4, 2025
@austinvazquez austinvazquez requested a review from thaJeztah March 4, 2025 16:23
Copy link
Member Author

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release binaries will continue to be built in Ubuntu 20.04 container images so no cause for concern for dropping support for older GLIBC versions at this time. This PR only updates the underlying compute.

build:
name: Build Release Binaries
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
Copy link
Member

@thaJeztah thaJeztah Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some discussion related to this, because a large number of users will still be on older versions of Ubuntu, and IIRC, compiling on newer versions will break packages for those;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be fine though right as we are continuing to build within a ubuntu-20.04 container or is somehow libseccomp dependency coming from the host?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't change the output and we will test the configuration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be fine though right as we are continuing to build within a ubuntu-20.04 container

Is this something that we should be doing. ubuntu-20.04 will go EOL in April 2025. Similar reason why we upgraded from ubuntu 18.04 to ubuntu 20.04 in #7961

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, does anyone know if Canonical's extended security support extends to their container images? I assume so. If which case, containerd 1.6 will go EOL in July and containerd 1.7 next March.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we should have a separate discussion about moving up the actual system libraries that the binaries link to (which is ubuntu 20.04, because we use a container for the actual build in the release action)

@github-project-automation github-project-automation bot moved this from Needs Triage to Review In Progress in Pull Request Review Mar 6, 2025
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@AkihiroSuda AkihiroSuda added this pull request to the merge queue Mar 6, 2025
Merged via the queue into containerd:main with commit 9deb0b8 Mar 6, 2025
58 checks passed
@github-project-automation github-project-automation bot moved this from Review In Progress to Done in Pull Request Review Mar 6, 2025
@estesp estesp added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Apr 16, 2025
@estesp
Copy link
Member

estesp commented Apr 16, 2025

/cherrypick release/2.0

@k8s-infra-cherrypick-robot

@estesp: new pull request created: #11703

Details

In response to this:

/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@estesp estesp added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/github_actions Pull requests that update GitHub Actions code area/toolchain Build and Release Toolchain cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch size/XS

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants