Skip to content

fix: set the credentials even if not provided #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Nov 19, 2024
Merged

fix: set the credentials even if not provided #10917

dmcgowan merged 1 commit into from
Nov 19, 2024

Conversation

@smira
Copy link
Contributor

@smira smira commented Oct 29, 2024

Fixes #10916

@smira
fix: set the credentials even if not provided
11b1353 
Fixes containerd#10916

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 29, 2024

Hi @smira. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dosubot dosubot bot added the kind/bug label Oct 29, 2024
@smira
Copy link
Contributor Author

smira commented Oct 29, 2024

I'm not sure if this is a proper fix, but it does fix this issue.

@danacr
Copy link

danacr commented Nov 5, 2024

can we merge this?

smira added a commit to smira/pkgs that referenced this pull request Nov 6, 2024
@smira
feat: update containerd to v2.0.0
bb3bf95 
Include the patch containerd/containerd#10917

See siderolabs/talos#9594

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this pull request Nov 6, 2024
Merged
smira added a commit to smira/pkgs that referenced this pull request Nov 6, 2024
@smira
feat: update containerd to v2.0.0
9a98f73 
Include the patch containerd/containerd#10917

See siderolabs/talos#9594

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/pkgs that referenced this pull request Nov 12, 2024
@smira
feat: update containerd to v2.0.0
60db990 
Include the patch containerd/containerd#10917

See siderolabs/talos#9594

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 9a98f73)
smira added a commit to smira/pkgs that referenced this pull request Nov 12, 2024
@smira
feat: update containerd to v2.0.0
747c6c7 
Include the patch containerd/containerd#10917

See siderolabs/talos#9594

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 9a98f73)
fuweid
fuweid reviewed Nov 19, 2024
View reviewed changes
@fuweid fuweid added the cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch label Nov 19, 2024
@fuweid
Copy link
Member

fuweid commented Nov 19, 2024

ping @dmcgowan @AkihiroSuda @mxpv

@dmcgowan dmcgowan added this pull request to the merge queue Nov 19, 2024
Merged via the queue into containerd:main with commit a987be4 Nov 19, 2024
@fuweid
Copy link
Member

fuweid commented Nov 19, 2024

/cherrypick release/2.0

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Nov 19, 2024

@fuweid: new pull request created: #11031

Details

In response to this:

/cherrypick release/2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 19, 2024
Merged
@fuweid fuweid added cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch and removed cherry-pick/2.0.x Change to be cherry picked to release/2.0 branch labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

cherry-picked/2.0.x PR commits are cherry picked into the release/2.0 branch kind/bug needs-ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

containerd (v2.0.0) fails to provide credentials when pulling sandbox image

6 participants

@smira @k8s-ci-robot @danacr @fuweid @k8s-infra-cherrypick-robot @dmcgowan