Hi @benjaminp. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

CI failing

 Version '2022.02-3ubuntu0.22.04.2' for 'ovmf' was not found

Please try rebasing

I've now rebased.

I don't think this is needed, containerd.service has an implicit After=basic.target (see systemctl show containerd -p After), and dbus has an explicit Before=basic.target (systemctl cat dbus | grep Before)
EDIT: on EL9, on EL8 dbus has no Before

sidenote: the same thing can be said for local-fs.target, it is implied in basic.target (see the graphic in man 7 bootup)

I don't think this is needed, containerd.service has an implicit After=basic.target (see systemctl show containerd -p After), and dbus has an explicit Before=basic.target (systemctl cat dbus | grep Before) EDIT: on EL9, on EL8 dbus has no Before

The upstream dbus service file does not have a Before dependency on basic.target. As you've noted, some distributions or distribution versions add this Before. It's safest for the containerd.service to be explicit for the lowest common denominator.

As the PR request message notes, the need for this dependency most is most acutely demonstrated in practice during shutdown. It's undesirable to have dbus shut down when containerd is still managing runc containers.

Actually EL9 / Fedora use dbus-broker (https://github.com/bus1/dbus-broker/blob/main/src/units/system/dbus-broker.service.in) and not the original dbus, thus the difference in unit files.
After=dbus.service is indeed needed for distro using the original dbus.