Use IoctlSetPointerInt from golang.org/x/sys/unix#40
Merged
estesp merged 2 commits intocontainerd:masterfrom Sep 16, 2020
Merged
Use IoctlSetPointerInt from golang.org/x/sys/unix#40estesp merged 2 commits intocontainerd:masterfrom
estesp merged 2 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
3e6019e to
d654f43
Compare
Use unix.IoctlSetPointerInt instead of manually implementing it. This fixes the build on darwin where direct syscalls, i.e. unix.Syscall(SYS_IOCTL, ...) are no longer allowed and exported as of golang/sys@6fcdbc0 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
d654f43 to
22cf7f1
Compare
Member
|
Thank you! I posted #39, and then realised that the changes in moby/term were because of the same issue, but didn't find the time yet to look into it <3 |
Member
This was referenced Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the golang.org/x/sys/unix dependency and use unix.IoctlSetPointerInt
instead of manually implementing it. This fixes the build on darwin
where direct syscalls, i.e. unix.Syscall(SYS_IOCTL, ...) are no longer
allowed and exported as of golang/sys@6fcdbc0
This should unblock #39 /cc @thaJeztah