Skip to content

[do not merge] containerd/console is broken with current golang.org/x/sys#39

Closed
thaJeztah wants to merge 2 commits intocontainerd:masterfrom
thaJeztah:update_x_sys
Closed

[do not merge] containerd/console is broken with current golang.org/x/sys#39
thaJeztah wants to merge 2 commits intocontainerd:masterfrom
thaJeztah:update_x_sys

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Sep 14, 2020

As mentioned in docker/buildx#389

Needed to downgrade sys/unix with replace rule because the new one (that cli requires through moby/term) does not build with moby/moby and containerd/console. golang/sys@6fcdbc0 Moby isn't big issue as could be upgraded/removed but containerd package looks like a chunk of work (especially because on first look package itself does not seem to be implemented correctly)

opening this to discuss (not sure what the right fix/change is yet)

@thaJeztah
vendor: pkg/errors v0.9.1
26c6122 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
go.mod update golang.org/x/sys v0.0.0-20200909081042-eff7692f9009
1bc0cee 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 14, 2020

CI doesn't run on macOS, but this is the compile failure;

# github.com/containerd/console
./tc_darwin.go:33:31: undefined: unix.SYS_IOCTL

console/tc_darwin.go

Line 33 in af5b089

if _, _, err := unix.Syscall(unix.SYS_IOCTL, fd, flag, data); err != 0 {

@thaJeztah thaJeztah mentioned this pull request Sep 15, 2020
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 15, 2020

This probably needs similar changes as were made in moby/term#16 @tklauser ?

@tklauser tklauser mentioned this pull request Sep 16, 2020
Merged
@tklauser
Copy link
Copy Markdown
Contributor

tklauser commented Sep 16, 2020

This probably needs similar changes as were made in moby/term#16 @tklauser ?

Yes, looks like it. I've sent #40 with a fix.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Sep 16, 2020

let me close this one, now that #40 is up

@thaJeztah thaJeztah closed this Sep 16, 2020
@thaJeztah thaJeztah deleted the update_x_sys branch September 16, 2020 10:15
@thaJeztah thaJeztah mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @tklauser