Skip to content

feat(v2): Support cgroup.MoveTo in cgroupv2 manager #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 2 commits into from
Jun 25, 2022
Merged

feat(v2): Support cgroup.MoveTo in cgroupv2 manager #235

AkihiroSuda merged 2 commits into from
Jun 25, 2022

Conversation

@yaoyinnan
Copy link
Contributor

@yaoyinnan yaoyinnan commented Jun 6, 2022

Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup.

Fixes: #234

Signed-off-by: yaoyinnan yaoyinnan@foxmail.com

@yaoyinnan
Cgroup v2: Support cgroup.MoveTo in cgroupv2 manager
8ff714d 
Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup.

Fixes: containerd#234

Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>
@yaoyinnan yaoyinnan changed the title Cgroup v2: Support cgroup.MoveTo in cgroupv2 manager feat(v2): Support cgroup.MoveTo in cgroupv2 manager Jun 8, 2022
@yaoyinnan yaoyinnan mentioned this pull request Jun 9, 2022
Merged
@yaoyinnan
Copy link
Contributor Author

yaoyinnan commented Jun 15, 2022

@estesp Please help me review this PR. kata-containers/kata-containers#4397 needs this PR to be merged. Thanks.

@estesp
Copy link
Member

estesp commented Jun 15, 2022

Given there is no test, how have you validated this works properly on cgroups v2? I notice that it works differently than the v1 MoveTo and curious if the error condition is the exact same (given it uses string matching).

@estesp estesp requested a review from AkihiroSuda June 15, 2022 14:46
@yaoyinnan
Copy link
Contributor Author

yaoyinnan commented Jun 17, 2022

@estesp I tested the error in the cgroupv2 environment, the error message contains "no such process", the content is as follows:

error="error: write /sys/fsrouproup.procs: no such process"

This MoveTo() method exists in cgroup v1, but does not exist in cgroup v2's Manager. I need to be compatible with this method in order to make Kata compatible with cgroup v1 and cgroup v2 systems. In Kata I tested this function and it works fine.

estesp
estesp approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaoyinnan
Copy link
Contributor Author

yaoyinnan commented Jun 18, 2022

@AkihiroSuda Please help me review this PR. Thanks.

@yaoyinnan
Copy link
Contributor Author

yaoyinnan commented Jun 23, 2022 •
edited
Loading

@estesp Please help me contact @AkihiroSuda to help me review this PR, the kata-containers/kata-containers#4397 needs to wait for #235 to be merged. Thanks.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jun 23, 2022

Please consider adding a test

@yaoyinnan
Cgroup v2: Add unit test TestMoveTo
2d6fcba 
Add unit test TestMoveTo() for manager.MoveTo().

Fixes: containerd#234

Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>
@yaoyinnan
Copy link
Contributor Author

yaoyinnan commented Jun 24, 2022

@AkihiroSuda I have added the test.

@AkihiroSuda AkihiroSuda merged commit cf7417b into containerd:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cgroup v2: Support cgroup.MoveTo in cgroupv2 manager

3 participants

@yaoyinnan @estesp @AkihiroSuda