Skip to content

Add GetSnapshot RPC#586

Merged
bswartz merged 1 commit into
container-storage-interface:masterfrom
xing-yang:GetSnapshot
May 15, 2025
Merged

Add GetSnapshot RPC#586
bswartz merged 1 commit into
container-storage-interface:masterfrom
xing-yang:GetSnapshot

Conversation

@xing-yang

Copy link
Copy Markdown
Contributor

What type of PR is this?
feature

What this PR does / why we need it:
This PR adds a GetSnapshot RPC

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce an API-breaking change?:

Adds GetSnapshot RPC.

Comment thread spec.md Outdated
Comment thread spec.md Outdated

@bswartz bswartz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nixpanic nixpanic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! You probably want to squash the commits into one before it gets merged?

@xing-yang

Copy link
Copy Markdown
Contributor Author

Squashed the commits.

nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Apr 28, 2025
See-also: container-storage-interface/spec#586
Signed-off-by: Niels de Vos <ndevos@ibm.com>

@nixpanic nixpanic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It has obviously been an omission, and I can imaging COs would want to use this. Can you leave a link in the comments where this new procedure would be used?

@bswartz

bswartz commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Thanks!

It has obviously been an omission, and I can imaging COs would want to use this. Can you leave a link in the comments where this new procedure would be used?

It's expected that statically provisioned group snapshots would use this API to populate information about the individual members of the group snapshot. Today we don't have a good way of getting the necessary information in that case. One hack is to rely on ListSnapshots with a snapshot ID passed in, but many drivers don't support that, due to other challenges related to snapshot listing.

@jdef

jdef commented Apr 28, 2025 via email

Copy link
Copy Markdown
Member

@xing-yang

xing-yang commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

@jdef Here is the KEP: https://github.com/kubernetes/enhancements/pull/5013/files
ListSnapshots API works as well, however, many storage vendors could not support list snapshots due to the performance overhead.
Usually storage vendors do not have a problem supporting GetSnapshot if they want to support volume snapshot or volume group snapshot.

@bswartz

bswartz commented May 1, 2025

Copy link
Copy Markdown
Contributor

Is there a KEP that describes the use case? Unclear why the list API doesn't work here. James DeFelice

@jdef This proposal seemed pretty uncontroversial to me. Do you want us to wait while you review the KEP before approving?

I think that there are some vendors that can't implement a real List and they're uncomfortable implementing a List that only works in certain cases (like returning a snapshot when the ID is passed in, but returning nothing when no ID is passed in). Even though singleton-List works, it's a kludge compared to a dedicated Get API. I think we've learned that we eventually need Get APIs across the board, and there's little point in trying to avoid adding them.

@bswartz

bswartz commented May 14, 2025

Copy link
Copy Markdown
Contributor

Last call before I merge this

@jdef

jdef commented May 14, 2025 via email

Copy link
Copy Markdown
Member

@jdef

jdef commented May 14, 2025 via email

Copy link
Copy Markdown
Member

@bswartz bswartz merged commit a539b4f into container-storage-interface:master May 15, 2025
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 15, 2025
See-also: container-storage-interface/spec#586
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 20, 2025
See-also: container-storage-interface/spec#586
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request May 20, 2025
See-also: container-storage-interface/spec#586
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jun 5, 2025
See-also: container-storage-interface/spec#586
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants