fixes windows composite key: #102 - add composite key#103
fixes windows composite key: #102 - add composite key#103pksunkara merged 3 commits intoconsole-rs:masterfrom
Conversation
|
Okay, what is a composite key and how is it related to macos and linux? |
|
As stated in the linked issue, the composite key does not really exist. It also does not relate to linux. The mapping is more for the Alt key - however, calling it Key::Alt seemed misleading as the mapping within winapi seems to be incorrect as well (it points to the Menu key instead). The issue is that the windows term generates Key::Unknown + Key::Char events when using this technique. (You should be able to reproduce this by using altGr + / to create a ¿ character). This causes dialoguer to crash. |
|
If you check https://docs.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes, VK_MENU is ALT key. So, instead of composite, let's put |
|
Then I misunderstood that. I will use Key::Alt then instead. Thank you very much! |
Based on some [earlier feedback][1], this PR changes the proto definition so readiness of a poll op is represented via a bool. The relevant changes have been made to: tokio-rs/tokio#4072 [1]: tokio-rs/console#77 (comment) Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
#102 - Text input yields Key::Unknown on windows_term using alt