Reconcile test cases w/ latest spec changes and fixes from latest connect-go#826
Merged
Reconcile test cases w/ latest spec changes and fixes from latest connect-go#826
Conversation
a60b6c9 to
8cc521a
Compare
… up known failing for grpcserver w/ grpc-web accordingly
Merged
akshayjshah
approved these changes
Mar 21, 2024
Contributor
akshayjshah
left a comment
There was a problem hiding this comment.
Some small nits and questions, but this looks good to me! If subsequent changes are limited to comments and potentially splitting the Connect & gRPC assertions for unexpected content types, fine to merge without another review.
internal/app/connectconformance/testsuites/data/server_unexpected.yaml
Outdated
Show resolved
Hide resolved
…otocols so we can be less lenient with connect protocol than grpc/grpc-web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to the latest connect-go release and reconciles the test cases with the latest spec changes (from connectrpc/connectrpc.com#130). It also enables some other tests that were waiting on connect-go fixes and cleans up the "known failing" lists based on these fixes and the new test cases. Finally, there are some tweaks to gRPC test cases, related to relaxing error code assertions.
This should be the last thing we need before releasing v1.0.0-rc4.
Resolves #810.
This also brings in a fix in connect-go that resolves #813.