Conversation
emcfarlane
approved these changes
Mar 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is effectively a continuation of #659, catching two more places that needed to be instrumented.
This issue was discovered when running conformance tests (connectrpc/conformance#813). It was occurring consistently with full-duplex streams against one particular server implementation. I think that implementation was eagerly doing a server-side cancelation of the stream when the server saw that its deadline had elapsed, and that other implementations generally don't do this. In this particular case, the framework was observing the "RSTStream" frame and returning a "canceled" code even though the operation's context had already elapsed and had a "deadline exceeded" error. So the RPC was returning a "canceled" error code when it ideally would instead return a "deadline exceeded" code. This PR fixes that discrepancy.