Fix delete in in-memory store, and let delete return old value#73
Merged
Guozhang Wang (guozhangwang) merged 1 commit intoSep 23, 2015
Conversation
|
lgtm |
Guozhang Wang (guozhangwang)
added a commit
that referenced
this pull request
Sep 23, 2015
Fix delete in in-memory store, and let delete return old value
Andrew Egelhofer (andrewegel)
pushed a commit
that referenced
this pull request
Nov 16, 2021
List of commits from kafka-broker-plugins: * Include all transitive dependencies in assembly (#71) * Add OAuth LoginCallbackHandler for the Kafka server (#72) * CPKAFKA-1593: Multi-tenant authorizer for CCloud (#66) * CPKAFKA-1593: Integration tests for multi-tenant authorizer for CCloud (#67) * CAAS-1960: Implement Phase 3.1 Metrics (#76) * CAAS-1960: Add authenticated connections and authentication rate metrics per tenant (#77) * Bump Confluent to 5.2.0-SNAPSHOT, Kafka to 2.2.0-SNAPSHOT * Topic config constraints (#70) * Remove redundant import in MultiTenantRequestContext (#79) * 4.1.x to 5.0.x (#78) * 5.0.x to 5.1.x (#82) * CPKAFKA-1408: Add tenant throughput and request quota plugin (#68) * Improve topic policy checks (#81) * CPKAFKA-1410: Partition assignor to balance partitions at tenant level (#73) * CPKAFKA-1694: Add partition throughput percentiles for monitoring (#84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ymatsuda
Currently the delete() call does not really remove the key-value pair in the tree map, making it not feasible with nullable values, and also takes unnecessary memory usage.