Fix a series of secret logging leakage issues#584
Merged
Conversation
…methods Current below log statements are not useful. This PR logs readable/masked configs during alterBrokerConfigs/alterTopicConfigs method call. `[Admin Manager on Broker 1]: Updating topic test with new configuration kafka.server.KafkaConfigc9ba35e3` Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Chia-Ping Tsai <chia7712@gmail.com> Closes apache#9824 from omkreddy/admin-logs
…ache#3849) This issue has been there for multiple years. Also adjust the logging to only include overridden topic configs, I _think_ this behavior changed unintentionally as part of the kraft work (and made the original issue worse). Unit test included and also tested manually. Reviewer: Alok Nikhil <anikhil@confluent.io>, Kowshik Prakasam <kprakasam@confluent.io>
Aadithya Chandra (ditac)
left a comment
There was a problem hiding this comment.
Can you provide links to the JIRA or commits for RequestChannel and AdminManager changes?
Author
Yes, I updated the commit info. |
Aadithya Chandra (ditac)
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes:
https://confluentinc.atlassian.net/browse/KC-1752
https://confluentinc.atlassian.net/browse/KC-1625
https://confluentinc.atlassian.net/browse/KSTORAGE-1626
Backport of as well: 52ca610