MINOR: Update log statements in alterBrokerConfigs/alterTopicConfigs methods#9824
Closed
omkreddy wants to merge 3 commits into
Closed
MINOR: Update log statements in alterBrokerConfigs/alterTopicConfigs methods#9824omkreddy wants to merge 3 commits into
omkreddy wants to merge 3 commits into
Conversation
rajinisivaram
approved these changes
Jan 5, 2021
rajinisivaram
left a comment
Contributor
There was a problem hiding this comment.
@omkreddy Thanks for the PR, LGTM
Contributor
Author
|
@chia7712 Thanks for the review . addressed the review comment. |
chia7712
approved these changes
Jan 6, 2021
| alterConfigOp.opType() match { | ||
| case OpType.SET => Log4jController.logLevel(loggerName, logLevel) | ||
| case OpType.DELETE => Log4jController.unsetLogLevel(loggerName) | ||
| case OpType.SET => { |
YiDing-Duke
pushed a commit
to YiDing-Duke/kafka
that referenced
this pull request
Jun 7, 2021
…methods Current below log statements are not useful. This PR logs readable/masked configs during alterBrokerConfigs/alterTopicConfigs method call. `[Admin Manager on Broker 1]: Updating topic test with new configuration kafka.server.KafkaConfigc9ba35e3` Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Chia-Ping Tsai <chia7712@gmail.com> Closes apache#9824 from omkreddy/admin-logs
YiDing-Duke
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jun 7, 2021
…methods Current below log statements are not useful. This PR logs readable/masked configs during alterBrokerConfigs/alterTopicConfigs method call. `[Admin Manager on Broker 1]: Updating topic test with new configuration kafka.server.KafkaConfigc9ba35e3` Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Chia-Ping Tsai <chia7712@gmail.com> Closes apache#9824 from omkreddy/admin-logs
YiDing-Duke
pushed a commit
to YiDing-Duke/kafka
that referenced
this pull request
Jun 7, 2021
…methods Current below log statements are not useful. This PR logs readable/masked configs during alterBrokerConfigs/alterTopicConfigs method call. `[Admin Manager on Broker 1]: Updating topic test with new configuration kafka.server.KafkaConfigc9ba35e3` Author: Manikumar Reddy <manikumar.reddy@gmail.com> Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Chia-Ping Tsai <chia7712@gmail.com> Closes apache#9824 from omkreddy/admin-logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current below log statements are not useful. This PR logs readable/masked configs during alterBrokerConfigs/alterTopicConfigs method call.
[Admin Manager on Broker 1]: Updating topic test with new configuration kafka.server.KafkaConfig@c9ba35e3Committer Checklist (excluded from commit message)