implement StateStore methods in SlidingWindow#4
Merged
Conversation
|
ymatsuda Seems the class Value is not added? EDIT: never mind, just saw it in the same class file. |
There was a problem hiding this comment.
Shall we just move these functions below to Utils.java?
|
ymatsuda LGTM, do you want to merge it now? We can discuss the full windowing semantics later and improve based on this. |
ymatsuda
added a commit
that referenced
this pull request
Aug 21, 2015
implement StateStore methods in SlidingWindow
|
lgtm |
Geoff (granders)
pushed a commit
that referenced
this pull request
Jan 31, 2016
Author: Michael Blume <mike@loggly.com> Reviewers: Guozhang Wang Closes #4 from MichaelBlume/patch-1
3 tasks
Andrew Egelhofer (andrewegel)
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Adding Dockerfile build * Minor cleanup
Sushant Mahajan (smjn)
added a commit
that referenced
this pull request
Aug 6, 2024
* AKCORE-254: RPC batching and event based poll. (#4) ### What - Build infra code to allow for RPC batching in PersisterStateManager. - Change poll mechanism to be triggered on various events (new RPC, completion of RPC on specific parition key etc.) ### Why - Batching improves performance by leveraging the turnaround time of an RPC on a specific node n1 (share coord leader) to batch multiple RPCs into a single one for subsequent requests. For example: - Suppose we get a Write RPC r1 for n1. - We send this RPC in standard way. - While r1 is inflight, lets say 3 more RPCs for n1 are received (r2, r3, r4) - coalesce and batch r2, r3, and r4 into a single RPC R1. - When r1 completes, make a single RPC R1 to n1 - This saves 2 network calls. - The result of R1 is broken down to create response objects for individual RPCs (r2, r3, r4) - Event based poll is more performant and simpler to implement. ### Testing - Added and updated tests at requisite places. * Incorporated review comments. (#6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guozhang Wang (@guozhangwang)