Corrected the MeteredKeyValueStore constructor's field initialization order to prevent NullPointerException#38
Closed
Randall Hauch (rhauch) wants to merge 1 commit into
Conversation
…ds so that the context is set before it is needed. This prevents a NullPointerException when running with a key value store.
|
Thanks for the PR, this is already resolved in the latest streaming branch. |
José Armando García Sancio (jsancio)
pushed a commit
that referenced
this pull request
Sep 13, 2019
…ent search (#38) As described in https://issues.apache.org/jira/browse/DIRSERVER-2257, there is a timing window in the persistent search handler in Apache DS because existing entries are processed before the persistent listener is created to process modifications. New entries created while existing entries are being processed, but before the persistent listener is created may never be returned to the client. This PR adds a workaround to ensure that missing entries are processed in the next iteration. Also adds error handling with retries during startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected order that MeteredKeyValueStore initialized its member fields so that the context is set before it is needed. This prevents a NullPointerException when running a topology with a key value store.