TopologyBuilder methods return the builder to allow methods to be chained together.#32
Merged
ymatsuda merged 2 commits intoSep 4, 2015
Conversation
|
Randall Hauch (@rhauch) Thank you for the pull request. There seems to be a conflict. Would you resolve it so that I can merge? |
…ined together. Since the methods returned void before, this has no other impact on existing code.
c30b286 to
88474e6
Compare
Author
|
ymatsuda, I've rebased upon the latest upstream branch, and also added JavaDoc for the public methods in |
11784aa to
a3f11eb
Compare
a3f11eb to
1a1bf8f
Compare
|
Thanks! |
ymatsuda
added a commit
that referenced
this pull request
Sep 4, 2015
…ment TopologyBuilder methods return the builder to allow methods to be chained together.
José Armando García Sancio (jsancio)
pushed a commit
that referenced
this pull request
Sep 13, 2019
…ction (#32) When the broker interceptor fails a request because it couldn't be transformed (e.g. invalid resource name or invalid principal that couldn't be prefixed), the interceptor throws an InvalidRequestException, which is propagated to the Processor processing the incoming receive. Processor treats this like any other invalid request/schema exception and closes the connection. For incoming requests which were successfully parsed but failed by the interceptor, this PR improves error handling by returning a response to the user with an INVALID_REQUEST error with the reason why the request was rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the methods returned
voidbefore, this change has no impact on existing code.