unnecessary check#28
Merged
Merged
Conversation
|
Lgtm |
Konstantine Karantasis (kkonstantine)
referenced
this pull request
in kkonstantine/kafka
Jan 4, 2017
I spent a bit of time tracking down why files were being deleted before they reached log.retention.hours of age. It turns out that the time and size log retention schemes function independently, and not as the original comment "The minimum age of a log file to be eligible for deletion" might indicate to a new user. Author: Mark Rose <markrose@markrose.ca> Reviewers: Guozhang Wang <wangguoz@gmail.com> Closes apache#28 from MarkRose/fix_misleading_configuration_file_for_trunk
José Armando García Sancio (jsancio)
pushed a commit
that referenced
this pull request
Sep 13, 2019
Conflicts: GroupCoordinatorIntegrationTest.scala - line 50 SocketServerTest.scala - TestableSocketServer class, removed verifyAcceptorIdlePercent() method, #1301 removed pollBlockMs var used in #1344 poll() method; testConnectionRateLimit() method changed SocketServer.scala - #82, removed SocketServerMetricsGroup var, #455 removed idlePercentMeter KafkaApis.scala - #50 imports RequestQuotaTest.scala - #28 imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guozhang Wang (@guozhangwang)
It is already done by AbstractConfig.