unify KeyValueMapper and KeyValueFlatMap#16
Merged
Conversation
|
LGTM. One related thought is that the input and output formats are now a bit different: we have two inputs K key, V value, with one output (of course :P) KeyValue. Do we want to unify the input to be also KeyValue<K, V>? Also in practice, type K would mostly be String, while type V maybe a Tuple that possibly wraps AvroGenericRecord, what do you think of optimizing ser-de overheads of intermediate results? |
ymatsuda
added a commit
that referenced
this pull request
Aug 28, 2015
unify KeyValueMapper and KeyValueFlatMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guozhang Wang (@guozhangwang)
This unifies KeyValueMapper and KeyValueFlatMap to reduce the number of functional interfaces. For Java7 users, their code will be a little bit more verbose. Java8 users using lambda expressions won't be affected.