Processor unit tests#15
Conversation
There was a problem hiding this comment.
Didn't this break a KStream test? KStream tests use MockProcessorContext.
Why did you move joinable() from ProcessorContext to KStreamJoin?
There was a problem hiding this comment.
I feel this function is specific to KStream not in Processor, as its checking logic is sort-of specific to KStream's definitions. Which tests need MockProcessorContext.joinable() calls?
There was a problem hiding this comment.
KStreamJoin should not care how the joinability is computed. So, having joinable() in ProcessorContext is actually good.
Anything that makes tests harder is bad since it is an indication of a bad code organization.
There was a problem hiding this comment.
Join is not a KStream specific concept.
There was a problem hiding this comment.
OK, will change it then.
There was a problem hiding this comment.
There is no unused imports, I will group o.a.k.s.kstream and o.a.k.s.processor.
There was a problem hiding this comment.
Sorry, I meant the clean up after you move joinable() back to ProcessContext.
|
Now "./gradlew stream:test" works, but 10 out of 29 tests fails.. Could we work in parallel to fix them after checking this in? |
|
OK. Let's merge your PR. |
Make unit testing workable
It is useful to know what the majority of failed authentications' causes are. This way, we can better understand what is happening with the system and gauge whether they might be intentional or not. Reviewers: Ismael, Rajini
ymatsuda
"./gradlew streaming:jar" succeeds again, finally.