kstream refactored#10
Merged
Guozhang Wang (guozhangwang) merged 4 commits intoAug 27, 2015
Merged
Conversation
added 2 commits
August 27, 2015 09:50
There was a problem hiding this comment.
Why do we want to wrap WindowInstance inside Window? Could Window.build() be triggered multiple times in a life-cycle of a task?
EDIT: now I realize it is for topology building and wrapped as ProcessorDef.build(). Maybe we can just rename them to WindowDef and Window for term-consistency?
|
One major comment on the KStreamWindowedImpl class, others are minor. Also I am assuming you are going to do the ProcessorDef renaming? |
|
LGTM. |
Guozhang Wang (guozhangwang)
added a commit
that referenced
this pull request
Aug 27, 2015
kstream refactored
|
I will rename ProcessorFactory to ProcessorDef. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guozhang Wang (@guozhangwang)