Skip to content

Delete pyarrow.json#3

Merged
beckermr merged 1 commit intomasterfrom
xhochy-patch-1
May 27, 2020
Merged

Delete pyarrow.json#3
beckermr merged 1 commit intomasterfrom
xhochy-patch-1

Conversation

@xhochy
Copy link
Copy Markdown
Member

@xhochy xhochy commented May 27, 2020

No description provided.

@xhochy xhochy requested a review from beckermr May 27, 2020 16:40
@beckermr beckermr merged commit 9654ffe into master May 27, 2020
@beckermr beckermr deleted the xhochy-patch-1 branch May 27, 2020 16:43
@isuruf
Copy link
Copy Markdown
Member

isuruf commented May 27, 2020

Should this be pyarrow and arrow-cpp instead?

@beckermr
Copy link
Copy Markdown
Member

What do you mean?

@isuruf
Copy link
Copy Markdown
Member

isuruf commented May 27, 2020

Until pyarrow-feedstock is archived, we should keep supporting it.

@xhochy
Copy link
Copy Markdown
Member Author

xhochy commented May 27, 2020

I'll archive it tomorrow morning when I merge the PR to arrow-cpp. I don't expect rebuilds to happen for older releases. If they happen, we can also revisit here.

@beckermr
Copy link
Copy Markdown
Member

beckermr commented May 27, 2020

Ahhhh. Removing an output here does not deprecate / remove support. If someone pushes a build between now and tomorrow, then the output will get readded. If that did happen, we would simply have to remove it again.

@beckermr
Copy link
Copy Markdown
Member

If we added the same output back with a different feedstock, that will remove support. If we know the new feedstock name, we can append it to current outputs to support both.

@isuruf
Copy link
Copy Markdown
Member

isuruf commented May 27, 2020

New feedstock name is arrow-cpp. Old one is pyarrow.

beckermr added a commit that referenced this pull request May 27, 2020
beckermr added a commit that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants