Fix dask-core pinning to properly exclude nightlies#218
Fix dask-core pinning to properly exclude nightlies#218jrbourbeau merged 2 commits intoconda-forge:mainfrom
dask-core pinning to properly exclude nightlies#218Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/distributed-feedstock/actions/runs/2868264018. |
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @charlesbluca! Seems reasonable to me -- @jakirkham do you have a minute to look at this?
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @charlesbluca -- will plan to merge this at EOD if no further comments
|
Have the same feedback as in the other review ( conda-forge/dask-feedstock#191 (review) ). Would suggest we keep this discussion in that thread for now and then apply whatever we decide to both PRs |
|
@jrbourbeau, could you please take a look at this as well? If this seems reasonable, would like to merge it before we merge the release PR. That way the new release will have the right version constraint to start 🙂 |
As brought up in conda-forge/dask-feedstock#190 (comment), the pinning introduced in #217 accidentally blocked the security backport proposal - tested this new pinning out locally and it seems to work with backports while also blocking nightly packages.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)