Skip to content

Tighten dask-core pinning#217

Merged
jrbourbeau merged 3 commits intoconda-forge:mainfrom
charlesbluca:patch-1
Aug 12, 2022
Merged

Tighten dask-core pinning#217
jrbourbeau merged 3 commits intoconda-forge:mainfrom
charlesbluca:patch-1

Conversation

@charlesbluca
Copy link
Copy Markdown
Member

@charlesbluca charlesbluca commented Aug 9, 2022

As part of addressing dask/dask#9367, this PR tightens the pinning of the dask-core dependency so that we can only pull in packages with an exact version match, preventing us from erroneously pulling in nightly packages.

cc @galipremsagar

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@charlesbluca
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 9, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/distributed-feedstock/actions/runs/2826875897.

recipe/meta.yaml Outdated
- cloudpickle >=1.5.0
- cytoolz >=0.8.2
- dask-core {{ version }}
- dask-core =={{ version }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as noted in comment ( https://github.com/conda-forge/dask-feedstock/pull/190/files#r941655804 ). Though we can discuss in that thread (instead of here) for simplicity.

Copy link
Copy Markdown
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 🙏

@jakirkham
Copy link
Copy Markdown
Member

@jrbourbeau, could you please take a look at this one too? 🙂

@jakirkham
Copy link
Copy Markdown
Member

Planning on merging EOD if no comments

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants