Bump to v0.18.6, finish py314 migration#114
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Seems that we are hitting this upstream bug, only on linux-64 + python 3.14: Traceback (most recent call last):
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/engine_v2.py", line 18, in <module>
from .model_implementations import InferenceV2Policy
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/model_implementations/__init__.py", line 12, in <module>
from .llama_v2 import *
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/model_implementations/llama_v2/__init__.py", line 6, in <module>
from .policy import Llama2Policy
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/model_implementations/llama_v2/policy.py", line 10, in <module>
from .container import Llama2NonTransformerContainer, Llama2TransformerContainer
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/model_implementations/llama_v2/container.py", line 42, in <module>
class Llama2TransformerContainer(LayerContainer):
...<20 lines>...
}
File "$PREFIX/lib/python3.14/site-packages/deepspeed/inference/v2/model_implementations/layer_container_base.py", line 97, in __new__
raise ValueError(
"Target parameter \"{}\" not found in this layer. Valid targets are {}".format(
base_dependency, all_names))
ValueError: Target parameter "qkv_w" not found in this layer. Valid targets are [] |
|
We could simply disable tests in py3.14 for the time being, or try to lend a hand fixing upstream, or both. What do you think @weiji14? |
|
Maybe give the deepspeed devs a few days and see if they do a bugfix release. Edit: actually, the test is failing on the top-level |
|
Waiting for deepspeedai/DeepSpeed#7831 |
Current metaclasses for layers and parameters access annotations in a way that is incompatible with python 3.14+ See: - [Python 3.14 release notes](https://docs.python.org/3/whatsnew/3.14.html) - [Porting annotations](https://docs.python.org/3/whatsnew/3.14.html#whatsnew314-porting-annotations) - [PEP649](https://peps.python.org/pep-0649/) and [PEP749](https://peps.python.org/pep-0749/) This PR uses annotationlib from python 3.14 onwards and keeps backwards compatibility. closes #7673 should unblock CF builds for py3.14 conda-forge/deepspeed-feedstock#114 A question is, does deepspeed support officially 3.14 yet? Should we test it in CIs? --------- Signed-off-by: Santi Villalba <sdvillal@gmail.com> Co-authored-by: Masahiro Tanaka <81312776+tohtana@users.noreply.github.com>
|
Upstream PR was merged, let's wait for a new release to be cut and update the PR. |
45cb83a to
8969a03
Compare
|
Weirdly only in python 3.11 we are failing to find this header file: Problem with the pytorch package? |
|
Here the weird difference between the failing python 3.11 build and the successful python 3.12: Which I feel boils down to the weird include line in python 3.11: Do you have a quick idea of what might be happening here with the python 3.11 build @h-vetinari @mgorny ? |
|
Quite weird. There were some header-related changes recently, but it seems that both builds used a matching |
|
Ok, clearly something went wrong and |
|
Wait a minute, that path is coming from Python itself! Python 3.11.14 | packaged by conda-forge | (main, Jan 26 2026, 23:48:32) [GCC 14.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sysconfig
>>> sysconfig.get_config_var("prefix")
'/home/conda/feedstock_root/build_artifacts/python-split_1769470388965/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol'Curious enough, I can't reproduce it in plain Python 3.11.14 | packaged by conda-forge | (main, Jan 26 2026, 23:48:32) [GCC 14.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sysconfig
>>> sysconfig.get_config_var("prefix")
'/srv/p2p/conda/miniforge3/envs/test'Is it a bug in rattler-build perhaps? |
|
Thanks a lot for looking @mgorny ! |
waiting for prefix-dev/rattler-build#2147 to be resolved will open a PR for the opposite selection, and remove the selector on a ci skip later
|
Pragmatically, we are now skipping all python 3.11 builds - likely unnecessarily broad but also minimal impact as we have a py3.11 package for the recent previous patch version. The key is to already enable people who need a python 3.14 build with an option. Plan: I will open a new PR for python 3.11. Let's keep an eye on the rattler-build fix for the prefix expansion problem, merge when ready, and finally remove the python version selector directly in main with a ci skip commit. @weiji14 FYI |
|
I haven't tested it, but I think a cheap workaround would be to |
I tried (hopefully correctly) but it seems it did not work |
Current metaclasses for layers and parameters access annotations in a way that is incompatible with python 3.14+ See: - [Python 3.14 release notes](https://docs.python.org/3/whatsnew/3.14.html) - [Porting annotations](https://docs.python.org/3/whatsnew/3.14.html#whatsnew314-porting-annotations) - [PEP649](https://peps.python.org/pep-0649/) and [PEP749](https://peps.python.org/pep-0749/) This PR uses annotationlib from python 3.14 onwards and keeps backwards compatibility. closes deepspeedai#7673 should unblock CF builds for py3.14 conda-forge/deepspeed-feedstock#114 A question is, does deepspeed support officially 3.14 yet? Should we test it in CIs? --------- Signed-off-by: Santi Villalba <sdvillal@gmail.com> Co-authored-by: Masahiro Tanaka <81312776+tohtana@users.noreply.github.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
Current metaclasses for layers and parameters access annotations in a way that is incompatible with python 3.14+ See: - [Python 3.14 release notes](https://docs.python.org/3/whatsnew/3.14.html) - [Porting annotations](https://docs.python.org/3/whatsnew/3.14.html#whatsnew314-porting-annotations) - [PEP649](https://peps.python.org/pep-0649/) and [PEP749](https://peps.python.org/pep-0749/) This PR uses annotationlib from python 3.14 onwards and keeps backwards compatibility. closes deepspeedai#7673 should unblock CF builds for py3.14 conda-forge/deepspeed-feedstock#114 A question is, does deepspeed support officially 3.14 yet? Should we test it in CIs? --------- Signed-off-by: Santi Villalba <sdvillal@gmail.com> Co-authored-by: Masahiro Tanaka <81312776+tohtana@users.noreply.github.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This finishes the python 3.14 migration. #113 was never reopened by the autotick bot, I suspect that it got confused by us cherry-picking the commit but later reverting in #112.
Also removes "5.0" from arch list, as per @weiji14 comment in #112.