Skip to content

Use cuda-nvcc-impl instead of cuda-nvvm to ensure compatibility across CUDA 12#131

Merged
leofang merged 11 commits intoconda-forge:mainfrom
bdice:use-cuda-nvcc-impl
Jul 11, 2025
Merged

Use cuda-nvcc-impl instead of cuda-nvvm to ensure compatibility across CUDA 12#131
leofang merged 11 commits intoconda-forge:mainfrom
bdice:use-cuda-nvcc-impl

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Jul 11, 2025 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is testing a slightly different approach for #129 than #130. #130 splits up the package into two variants for >=12.0,<12.2 and >=12.2,<13.0. This simply uses cuda-nvcc-impl instead of cuda-nvvm, which increases the binary size of the dependency tree a tiny bit but ensures broader compatibility with all CUDA 12.x versions.

@bdice bdice changed the title Use cuda-nvcc-impl [TEST] Use cuda-nvcc-impl Jul 11, 2025
@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Jul 11, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of <output 0 output, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The feedstock is lowering the image versions for one or more platforms: {'linux_64': 'cos7', 'linux_aarch64': 'cos7', 'linux_ppc64le': 'cos7'} (the default is alma9). Unless you are in the very rare case of repackaging binary artifacts, consider removing these overrides from conda-forge.yml in the top feedstock directory.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16231070004. Examine the logs at this URL for more detail.

leofang
leofang approved these changes Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution better. I hit re-run. I don't think there are other ways.

@bdice bdice changed the title [TEST] Use cuda-nvcc-impl Use cuda-nvcc-impl Jul 11, 2025
@bdice bdice changed the title Use cuda-nvcc-impl Use cuda-nvcc-impl instead of cuda-nvvm to ensure compatibility across CUDA 12 Jul 11, 2025
bdice
bdice commented Jul 11, 2025
View reviewed changes
@bdice bdice mentioned this pull request Jul 11, 2025
Closed
5 tasks
@leofang
Copy link
Copy Markdown
Member

leofang commented Jul 11, 2025

Let's merge and rerun on main, thanks Bradley!

@leofang leofang merged commit 19eb9e3 into conda-forge:main Jul 11, 2025
5 of 18 checks passed
@bdice bdice mentioned this pull request Jul 14, 2025
Closed
1 task
@leofang leofang linked an issue Aug 7, 2025 that may be closed by this pull request
cuda-python 12.9 incompatible with cuda-version 12.0 #129
Closed
1 task
@cbouss cbouss mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@kkraus14 kkraus14 Awaiting requested review from kkraus14 kkraus14 is a code owner

@m3vaz m3vaz Awaiting requested review from m3vaz m3vaz is a code owner

@mmccarty mmccarty Awaiting requested review from mmccarty mmccarty is a code owner

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01 vzhurba01 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cuda-python 12.9 incompatible with cuda-version 12.0

3 participants

@bdice @conda-forge-admin @leofang