Skip to content

Rebuild cuda-bindings with and without cuda-nvvm#130

Closed
bdice wants to merge 8 commits intoconda-forge:mainfrom
bdice:split-build-nvvm
Closed

Rebuild cuda-bindings with and without cuda-nvvm#130
bdice wants to merge 8 commits intoconda-forge:mainfrom
bdice:split-build-nvvm

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Jul 11, 2025 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I discussed #129 with @kkraus14 and we decided to try splitting the build of cuda-bindings.

This PR splits the build of cuda-bindings into CUDA >=12.0,<12.2 using cuda-nvcc-impl and >=12.2,<13.0 using cuda-nvvm.

This is needed because the cuda-nvvm package does not exist for CUDA >=12.0,<12.2, and we must use cuda-nvcc-impl to get the same components.

This is my first time doing significant changes to this feedstock, so I'd like a careful review of how I'm using conda_build_config.yaml. There are some portions of this feedstock that are used to control the build of cuda-bindings vs. cuda-core.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Jul 11, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of <output 0 output, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The feedstock is lowering the image versions for one or more platforms: {'linux_64': 'cos7', 'linux_aarch64': 'cos7', 'linux_ppc64le': 'cos7'} (the default is alma9). Unless you are in the very rare case of repackaging binary artifacts, consider removing these overrides from conda-forge.yml in the top feedstock directory.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16227380041. Examine the logs at this URL for more detail.

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jul 11, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Jul 11, 2025

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16218898807. Examine the logs at this URL for more detail.

@bdice bdice mentioned this pull request Jul 11, 2025
Merged
5 tasks
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jul 11, 2025

Closing in favor of #131.

@bdice bdice closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@kkraus14 kkraus14 Awaiting requested review from kkraus14 kkraus14 is a code owner

@leofang leofang Awaiting requested review from leofang leofang is a code owner

@m3vaz m3vaz Awaiting requested review from m3vaz m3vaz is a code owner

@mmccarty mmccarty Awaiting requested review from mmccarty mmccarty is a code owner

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01 vzhurba01 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdice @conda-forge-admin