Update labels in CFEP 5 to align with consensus in discussion#21
Merged
ocefpaf merged 1 commit intoconda-forge:masterfrom Feb 6, 2020
Merged
Update labels in CFEP 5 to align with consensus in discussion#21ocefpaf merged 1 commit intoconda-forge:masterfrom
ocefpaf merged 1 commit intoconda-forge:masterfrom
Conversation
The original CFEP 5 had the labels as rc_package and dev_package. During the discussionof CFEP 5 (conda-forge#3), a discussion and survey ensued about whether the prerelease indicators should be before the package name or after: conda-forge#3 (comment) The results were that the prerelease indicators should be after, but the text of the CFEP was never updated. This commit updates the CFEP.
This was referenced Feb 6, 2020
Merged
Member
|
I don't think this needs a vote, since this is just implementing the text that we agreed to, but if anyone has objections I'll wait until Friday to merge (if there are no objections). Please feel free to merge before me @conda-forge/core |
jasongrout
added a commit
to jasongrout/cfep
that referenced
this pull request
Feb 6, 2020
…osition This follows up on conda-forge#21 to fix one more place that needs to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original CFEP 5 had the labels as
rc_packageanddev_package. During the discussion of CFEP 5, a discussion and survey ensued about whether the prerelease indicators should be before the package name or after. The results were that the prerelease indicators should be after, but the text of the CFEP was never updated. This commit updates the CFEP.