Skip to content

Update to 1.61#9

Merged
jakirkham merged 2 commits intoconda-forge:masterfrom
jschueller:patch-1
May 26, 2016
Merged

Update to 1.61#9
jakirkham merged 2 commits intoconda-forge:masterfrom
jschueller:patch-1

Conversation

@jschueller
Copy link
Copy Markdown
Contributor

No description provided.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan
Copy link
Copy Markdown
Member

The Windows logs are enormous because files are copied one-by-one. I didn't have the patience to wait for my browser to load the whole log to find the error. I recommend changing this recipe, potentially bypassing their built-in logic, and copying or (better) moving directories rather than individual files.

@jschueller
Copy link
Copy Markdown
Contributor Author

@msarahan, you can download the raw log file instead, it's a problem because of an hardcoded path.

@jakirkham
Copy link
Copy Markdown
Member

There still seems to be some path issue. I looked at the log, but it is pretty vague about the error.

@jschueller
Copy link
Copy Markdown
Contributor Author

@jakirkham great success!

@jakirkham
Copy link
Copy Markdown
Member

What was causing the problem?

recipe/bld.bat Outdated

:: Move dll's to LIBRARY_BIN
move %LIBRARY_LIB%\*vc%VSTRING%0-mt-1_60.dll "%LIBRARY_BIN%"
move %LIBRARY_LIB%\*vc%VSTRING%0-mt-1_61.dll "%LIBRARY_BIN%"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this appears to be a persistent feature, we should probably absorb it somehow. We probably can do something similar to this.

@jschueller
Copy link
Copy Markdown
Contributor Author

@jakirkham ok, applied

@ccordoba12
Copy link
Copy Markdown
Contributor

Great job @jschueller!!

@jschueller jschueller changed the title Try to update to 1.61 Update to 1.61 May 19, 2016
@jakirkham
Copy link
Copy Markdown
Member

Awesome @jschueller! I would like to merge this soon, but I realized earlier we are not pinning boost. If you guys could help me track down and pin boost to 1.60.x on packages that are using it, I would really appreciate it. This is not to say we won't upgrade to 1.61.x. Just that I'm worried about breaking people's existing stuff. I'm going to add WIP here until we have finished that.

@jakirkham jakirkham changed the title Update to 1.61 WIP: Update to 1.61 May 19, 2016
@jschueller
Copy link
Copy Markdown
Contributor Author

@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented May 19, 2016

I'm aware. Just help from others doing this pinning will be great as this is only one of many things that needs to get done.

@jakirkham
Copy link
Copy Markdown
Member

Thanks @jschueller. Couple points.

  • Build numbers must be bumped.
  • Let's do 1.60.* with that last ..

Otherwise, I'll merge them after this is changed.

@jakirkham
Copy link
Copy Markdown
Member

@ocefpaf @183amir, @kayhayen, if you are not aware, we are planning on releasing Boost 1.61.0. As this may contain ABI breaking changes, we have tried to track down feedstocks using Boost and add pinning PRs to fix them to 1.60.* (current). All of this has been done in no small part by @jschueller. If you have no strong objections and CI is passing, please merge the pinnings. I'll try to check back in on Monday and merge any stragglers so that we don't break your stacks when we release this. For the broken ones, we should probably figure out what is wrong and see how we can address it.

@jakirkham
Copy link
Copy Markdown
Member

Also, @jschueller, please feel free to add yourself to the maintainers list here.

@kayhayen
Copy link
Copy Markdown

kayhayen commented May 24, 2016 via email

@jakirkham jakirkham changed the title WIP: Update to 1.61 Update to 1.61 May 26, 2016
@jakirkham
Copy link
Copy Markdown
Member

Everything is pinned that needs to be so let's get 1.61.* out.

@jakirkham jakirkham merged commit 453de32 into conda-forge:master May 26, 2016
h-vetinari pushed a commit to h-vetinari/boost-feedstock that referenced this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants